Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default email template with extended base #268

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

Vardane
Copy link
Contributor

@Vardane Vardane commented Dec 13, 2020

Q R
Type of contribution ? Enhancement
Tickets (issues) concerned #246

What have you changed ?

Incorporated default template emails to be used when a participation gets created or cancelled.

How did you change it ?

Added .html and .txt template files; edited functions governing email creation on participation creation or deletion; added tests.

Is there a special consideration?

.html files extend a base.html file, which may conflict with SendinBlue behaviour. So consider merging enhancement-default_email_template branch instead of the branch in this current pull request.

Verification :

  • My branch name respect the standard defined in CONTRIBUTING.md
  • All my commits respect the standard defined in CONTRIBUTING.md
  • This Pull-Request fully meets the requirements defined in the issue
  • I added or modified the attached tests
  • I added or modified the documentation

@Vardane Vardane changed the title Enhancement default email template with extended base Added default email template with extended base Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants